ROCm/roctracer

Error building on ROCm 4.0

Closed this issue · 2 comments

Hi, while building the roctracer I am getting the error stating HCC support dropped. Is there a workaround or fix for this?

Steps to produce:
ROCm 4.0 + Docker image rocm/pytorch:rocm4.0_ubuntu18.04_py3.6_pytorch_1.7.0
Following the instructions, the error shows up at "make" state.

Error:

Scanning dependencies of target roctracer64
make[2]: Leaving directory '/rocDistributed/megatron-pytorch-distributed/roctracer/build'
make  -f CMakeFiles/roctracer64.dir/build.make CMakeFiles/roctracer64.dir/build
make[2]: Entering directory '/rocDistributed/megatron-pytorch-distributed/roctracer/build'
[ 21%] Building CXX object CMakeFiles/roctracer64.dir/src/core/roctracer.cpp.o
/opt/cache/bin/c++ -DAMD_INTERNAL_BUILD -DHIP_PROF_HIP_API_STRING=1 -DHIP_VDI=0 -DHSA_DEPRECATED="" -DHSA_LARGE_MODEL="" -DLINUX -DLITTLEENDIAN_CPU=1 -DLOCAL_BUILD=1 -DUNIX_OS -D__AMD64__ -D__HIP_PLATFORM_HCC__=1 -D__linux__ -D__x86_64__ -Droctracer64_EXPORTS -I/rocDistributed/megatron-pytorch-distributed/roctracer/src -I/rocDistributed/megatron-pytorch-distributed/roctracer -I/rocDistributed/megatron-pytorch-distributed/roctracer/inc -I/opt/rocm/include/hsa -I/opt/rocm/hip/include -I/opt/rocm/lib/../include -I/rocDistributed/megatron-pytorch-distributed/roctracer/build/inc -std=c++11 -Wall -Werror -Werror=return-type -fexceptions -fvisibility=hidden -fno-math-errno -fno-threadsafe-statics -fmerge-all-constants -fms-extensions -fmerge-all-constants -fPIC -m64  -msse -msse2 -O3 -DNDEBUG -fPIC -o CMakeFiles/roctracer64.dir/src/core/roctracer.cpp.o -c /rocDistributed/megatron-pytorch-distributed/roctracer/src/core/roctracer.cpp
In file included from /rocDistributed/megatron-pytorch-distributed/roctracer/src/core/roctracer.cpp:44:0:
/rocDistributed/megatron-pytorch-distributed/roctracer/src/core/loader.h:314:2: error: #error HCC support dropped
 #error HCC support dropped
  ^~~~~
CMakeFiles/roctracer64.dir/build.make:84: recipe for target 'CMakeFiles/roctracer64.dir/src/core/roctracer.cpp.o' failed
make[2]: *** [CMakeFiles/roctracer64.dir/src/core/roctracer.cpp.o] Error 1
make[2]: Leaving directory '/rocDistributed/megatron-pytorch-distributed/roctracer/build'
CMakeFiles/Makefile2:289: recipe for target 'CMakeFiles/roctracer64.dir/all' failed

Thanks!

I just got the same error. It seems that adding

-DHIP_VDI=1

to cmake fixed it. Maybe.

I'm not sure why nobody answered this earlier. This would seem an easy catch. Is anyone monitoring these issues?

@cagery Apologies for the lack of response. Did adding "-DHIP_VDI=1" to cmake resolve your issue? If so, please close the ticket. Thanks!