RPTools/TokenTool

Translation issues

Tdue21 opened this issue · 2 comments

Tdue21 commented

I have translated TokenTool to danish, but there are a number of issues, that I am unable to handle through translation of i18n properties alone.

Untranslatable

Portrait Options

This button and dropdown are not currently translatable:
image

I realize that the Custom Color dialog is probably a standard component, but still, it should be translatable.

Overlay Options

Likewise the default overlay folders and images are also fixed texts, that is not translatable.
image

Manage Overlays Dialog

Finally, the dialog for managing overlays has a couple of issues as well. The default overlays are not translatable as they seem to be hardcoded.

image

Again, the overlay name is hardcoded, as well as the file type, if it is a Photoshop file.

image

Azhrei commented

This is great — thank you! I'll talk to Jamz about getting this built (I've merged it), and we'll look into externalizing these other strings.

JamzTheMan commented

I'm pretty sure I now have everything externalized that can be. What can't be translated, or can't be without some pain/issues are:

  • Colors - Transparent and the other color names all come from the FX Color Picker. If that control doesn't have i18n translations, we would have to manually do that for all the colors (yuck).
  • The default overlays/folders are in fact "hard coded" as they are resource package names. Al the overlays are stored like any other java resource and reflection is used to extract and save them on demand. Although, once "extracted" they can be renamed if the user wants to. We would have to do some manual i18n work here and I would treat that as it's own enhancement issue to be created.
  • I think the file type names may be coming from the lib directly, Although there is a chance it's not. However, it's a proper name so "Adobe Photoshop" would be the same in all languages? (I'm just guessing here) but I suppose we could just put PSD here to match PNG/JPG and drop the "Image" and "File" wording?

Note If you can, double check your danish translation. There was a merge conflict because I had new properties added in 2.1, but I think I got the changes ok.