RRUZ/delphi-dev-shell-tools

"Open With Delphi" never work with ".dproj" extension.

Closed this issue · 5 comments

What steps will reproduce the problem?
1.
  Locate any Delphi project,make sure the dpr and dproj are there.
2.
  Locate the dproj file, select DDST tool's "Open with Delphi" menu.
3.
  The BDS.exe launched, but the project didn't opened at all.

What is the expected output? What do you see instead?

  The IDE should launched along with the project file.


What version of the product are you using? On what operating system?

Win7 32bit, Delphi XE5/XE6.

Please provide any additional information below.

The "Open with Delphi" simply launched with "$IDEInstallPath$\BDS.exe 
"-pDelphi" "-pDelphi".

v==================AddOpenWithDelphi====================v
LMethodInfo.Method:=DelphiDevShellTasks.OpenRADStudio;
LMethodInfo.Value1:=LCurrentDelphiVersionData;
LMethodInfo.Value2:=EmptyStr;
LMethodInfo.Value3:=FFileName;
if LCurrentDelphiVersionData.Version>=Delphi2007 then
  LMethodInfo.Value3:='-pDelphi';

if SameText(FFileExt, '.dpr') then
begin
    sValue:=ChangeFileExt(FFileName,'.dproj');
       if TFile.Exists(sValue) then
         LMethodInfo.Value2:=sValue;
end;
^==================AddOpenWithDelphi====================^
^^The LMethodInfo.Value2 will be alway equal EmptyStr^^


v====================OpenRADStudio======================v
if Info.Value2.AsString<>'' then
   LFileName:=Info.Value2.AsString
  else
   LFileName:=Info.Value3.AsString;

  ShellExecute(Info.hwnd, 'open', PChar(LDelphiVersion.Path), PChar(Format('"%s" "%s"',[LFileName, Info.Value3.AsString])) , nil , SW_SHOWNORMAL);
^====================OpenRADStudio======================^
^^The LFileName will be alway equal '-pDelphi'^^


Original issue reported on code.google.com by sxm...@gmail.com on 18 Apr 2014 at 6:39

LMethodInfo.Value2:=EmptyStr;
LMethodInfo.Value3:=FFileName;

modify to

LMethodInfo.Value2:=FFileName;
LMethodInfo.Value3:=EmptyStr;

will fix this.

Original comment by sxm...@gmail.com on 18 Apr 2014 at 6:49

[deleted comment]
Oh,there is one more little problem about the installer.

Launch the installer, right click the titlebar, select About Setup", click the 
"OK" button of the dialog. There will be an AV.

Just FYI.

Original comment by sxm...@gmail.com on 18 Apr 2014 at 7:06

Attachments:

This issue was closed by revision r47.

Original comment by Rodrigo.Ruz.V@gmail.com on 18 Apr 2014 at 2:43

  • Changed state: Fixed
The issue was fixed. Try the new version of the installer. Thanks for the 
report.

Original comment by Rodrigo.Ruz.V@gmail.com on 18 Apr 2014 at 2:44