Inconsistent treatment of non-auto speed settings
Opened this issue · 1 comments
bettinardi commented
I’m seeing three areas of inconsistent treatment:
- Mode speeds in the config file - https://github.com/RSGInc/SOABM/blob/master/template/config/orramp.properties#L169 vs mode speed hard coded - https://github.com/RSGInc/SOABM/blob/master/template/scripts/SOABM.py#L324
- Related, this treatment assumes that the users has coded mode speeds correctly / consistently in Visum as well: https://github.com/RSGInc/SOABM/blob/master/template/scripts/SOABM.py#L356
- The wiki guidance does not seem correct on this page: https://github.com/RSGInc/SOABM/wiki/non-motorized-network-coding
bettinardi commented
The proposed solution for this issue is to change the createMazToTap function - https://github.com/RSGInc/SOABM/blob/master/template/scripts/SOABM.py#L319
This function should be changed to use distance instead of time. This would make the following wiki page correct - https://github.com/RSGInc/SOABM/wiki/non-motorized-network-coding
It would also remove the non-auto mode coded speed inconsistency. Taking out the speed coded in Visum and in the createMazToTap function, and leaving just the speed in the config file.
@bstabler and @binnympaul, is there any issue with this solution - of changing createMazToTap to use distance instead of time?