Mark Quantumleap subscription as deprecated

Question

Mark Quantumleap subscription as deprecated

Closed this issue 3 months ago · 5 comments

In the current release (1.0.0) QuantumLeap no longer supports Subscription as it was just for convenience.

Look here:
orchestracities/ngsi-timeseries-api#748

Therefore, we at least need to catch the error returned and afterwards check version to return a proper Error message.
Even more, give a deprectation warning that the function will be removed in the next Versions of FiLiP.

Answer 1 · 2023-12-06T11:22:40.000Z

Besides, we should consider to change the default value of servicepaht to "/" https://github.com/RWTH-EBC/FiLiP/blob/f5f1d9fd4431b68d806e42cd494c00ad887c312e/filip/models/base.py#L86C1-L86C20. QL has already fixed that in the new release

"Fiware-servicePath was interpreted as python None, from now on, None will be replaced with /. This affects only users that manually injected data, since Orion, assume / when no servicePath is passed.."

Answer 2 · 2024-02-14T13:57:29.000Z

As mentioned in #239, this API has been removed in QL1.0.0. After testing the capability with QL1.0.0, all related code and test should be removed. Before that may be create a new tag like QL0.8.3

Answer 3 · 2024-03-06T15:56:59.000Z

ToDo list:

remove subscription endpoint
change default servcicepath to "/"
support idPattern as a query parameter

Answer 4 · 2024-03-06T15:58:00.000Z

Branch 215-Mark-Quantumleap-subscription-as-deprecated created!

Answer 5 · 2024-03-22T16:13:36.000Z

I could not test whether the id_pattern parameter is working because i am not even certain it is supported in Quantumleap itself. I tried testing it but got inconsistent results.
The subscribe method of the quantumleap client is now blocked by an initial assert statment, mainly so that a well defined error could be caught when testing...
Input on how either issues can be handled in a better way is very welcome.