RadioAstronomySoftwareGroup/pyuvdata

Make UVFlag add smarter

adampbeardsley opened this issue · 2 comments

Right now the UVFlag add method requires an axis to be specified and it blindly concatenates. We should make it smarter to check for compatibility and figure out which axis to add along, like UVData. Similar to UVData, we should also add a fast_concat method.

The current implementation of add basically is fast_concat luckily. Just need to build up checks for a more safe add.

Generally need to add more checking as is done with the other objects. In particular, make sure the right thing happens in the case of overlapping and differently sorted data.

see #1102 and #1105 for reference