RadxaOS-SDK/rsdk

direnv: command not found on `rsdk devcon up`

Closed this issue · 9 comments

zetxx commented

Following tutorial: https://radxaos-sdk.github.io/rsdk/install/devcontainer.html#common-issues gives me:
/workspaces/rsdk/src/bin/../libexec/rsdk/rsdk-setup: line 95: direnv: command not found on rsdk devcon up

last log:

 1 warning found (use docker --debug to expand):
 - InvalidDefaultArgInFrom: Default value for ARG $BASE_IMAGE results in empty or invalid base image name (line 4)
[3779 ms] Start: Run: docker run --sig-proxy=false -a STDOUT -a STDERR --mount type=bind,source=/store/Projects/radx/rsdk,target=/workspaces/rsdk --mount type=volume,src=nix-store-0k2rs8h3esrd933j9a2tcsdtaqgdqj7tket50nmqgorrdfutt2eo,dst=/nix --mount type=bind,src=/store/Projects/radx/rsdk/.devcontainer/.devenv,dst=/workspaces/rsdk/.devenv --mount type=bind,src=/store/Projects/radx/rsdk/.devcontainer/.direnv,dst=/workspaces/rsdk/.direnv -l devcontainer.local_folder=/store/Projects/radx/rsdk -l devcontainer.config_file=/store/Projects/radx/rsdk/.devcontainer/devcontainer.json --ulimit nofile=1024:524288 --cap-add SYS_ADMIN --privileged -v /dev:/dev --entrypoint /bin/sh vsc-rsdk-df414d48bd270aaeaf20f9dea929db41cf602d5c39e4b1babb0d511c78d793af-features-uid -c echo Container started
Container started
Running the updateContentCommand from devcontainer.json...

Running the postCreateCommand from devcontainer.json...

/workspaces/rsdk/src/bin/../libexec/rsdk/rsdk-setup: line 95: direnv: command not found
[4764 ms] postCreateCommand failed with exit code 127. Skipping any further user-provided commands.
Error: Command failed: /bin/sh -c src/bin/rsdk setup
    at fY (/store/Projects/radx/rsdk/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:235:130)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async rl (/store/Projects/radx/rsdk/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:227:4393)
    at async el (/store/Projects/radx/rsdk/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:227:3738)
    at async il (/store/Projects/radx/rsdk/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:227:2942)
    at async ds (/store/Projects/radx/rsdk/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:227:2386)
    at async K$ (/store/Projects/radx/rsdk/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:464:1488)
    at async $J (/store/Projects/radx/rsdk/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:464:960)
    at async tAA (/store/Projects/radx/rsdk/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:481:3660)
    at async CC (/store/Projects/radx/rsdk/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:481:4775)
{"outcome":"error","message":"Command failed: /bin/sh -c src/bin/rsdk setup","description":"The postCreateCommand in the devcontainer.json failed.","containerId":"3d6cb62e49a33055fc41f40d2eb8dfffe60a9f23d43bf65378dbd3e69d03580a"}
zetxx commented

Noticed in: .devcontainer/devcontainer.json line 22 there was definition of this package "direnv"
also placed on line 79 "postCreateCommand": "src/bin/rsdk setup" >> "postCreateCommand": "sudo apt install -y direnv && src/bin/rsdk setup" and container started after that ... however when i rsdk devcon there was an error: direnv: PS1 cannot be exported. For more information see https://github.com/direnv/direnv/wiki/PS1

Now trying to make a build.
EDIT:
build success

Do you mean you add apt install direnv to postCreateCommand? Because it is not there.

And yes, direnv should be installed by "features"."ghcr.io/devcontainers/features/nix:1"."packages". You need to check your full log to see why it failed.

zetxx commented

yep, correct, i added it in postCreateCommand
also, in the logs there is no any kind of errors

I'll close this for now until we get some error log or if we reproduce it. We just did a build yesterday and there was no issue when running rsdk-setup from GitHub's runner.

zetxx commented

issue has appeared after 12 pm utc

zetxx commented

@RadxaYuntian
My Fault, probably ... i totally forgot about git clone --recurse-submodules https://github.com/RadxaOS-SDK/rsdk.git .... --recurse-submodules
maybe it is wort mentioning in docs that regularly sub-modules should be pulled

It is already mentioned in the doc: https://radxaos-sdk.github.io/rsdk/install/devcontainer.html

It is supposed to be a complete copy-and-paste operation.

Also I don't think missing submodule has anything to do with direnv missing. Those are required to run rsdk itself, but not direnv.

zetxx commented

strange, this is the only thing that i did