RafalWilinski/express-status-monitor

Replace request-promise-native with lightweight http client

LogansUA opened this issue · 0 comments

Hello,

So basically the title is saying everything.

The main problem that request-promise-native library requires to have request library in each package.json (because request is a peer dependency for request-promise-native) which is using express-status-monitor.

I found this one http-client as really lightweight.
Here's comparison:

The got itself size:
screen shot 2018-10-26 at 12 55 22

The request and request-promise-native sizes:
screen shot 2018-10-26 at 12 56 02
screen shot 2018-10-26 at 12 56 21

Even axios is better:
screen shot 2018-10-26 at 12 56 45

Even better: since the it's simply GET request and the response data doesn't matter it would be really good to rewrite it using native http/https library (example)

Please consider to change it :)

Thank you.