Railly/one-hunter-vscode

Would it be possible to add a bit more contrast for the currently visible tab in the Light variant ?

max-g opened this issue ยท 4 comments

max-g commented

Really nice theme, I was wondering if you could make the current opened tab a bit more visible in the Light variant ?

It's kind of hard to see which one is currently visible. In the following screenshot SiteFooter.tsx is the one currently visible :

Screen Shot 2023-01-10 at 11 53 34

Sorry, I didn't see the notification of this issue. Sure, I'll look into it. If there were any other suggestions, feel free to share them with me. @max-g

max-g commented

It's totally subjective, but i like having the accent color of the theme as the top or lower border of the active tab, like in the Github and Ayu themes. I was thinking maybe the pink accent color would be nice.

eg:
Screenshot 2023-01-29 at 20 51 04
Screenshot 2023-01-29 at 20 50 28

Yup, I fully agree with you. I'll check out other light themes as well, because tbh I made this one really fast.
Annotated! ๐Ÿ“

max-g commented

I just realized that there is a setting that will output a top border for unsaved file :
Screenshot 2023-01-31 at 10 48 10

Here is how it shows on Github Light theme :

  • Current active tab == tab with unsaved changes :
    Screenshot 2023-01-31 at 10 50 51

  • Current active tab != tab with unsaved changes :
    Screenshot 2023-01-31 at 10 49 58

Here is how it shows on Ayu Light theme :

  • Current active tab == tab with unsaved changes :
    Screenshot 2023-01-31 at 10 50 44
  • Current active tab != tab with unsaved changes :
    Screenshot 2023-01-31 at 10 50 08