Ramilito/kubesess

arm release

b4nst opened this issue · 9 comments

b4nst commented

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

No release is available for arm target.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Having a arm release would be nice.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

cargo install --git https://github.com/Ramilito/kubesess.git

Additional context
Add any other context or screenshots about the feature request here.

That's a fair request, looked into the GitHub action I'm using and they don't support arm yet support more targets

I will have to use something else.
Really liked that one since it attaches binaries to the release automagically.

Just a note on your alternative solution.
The script kubesess.sh would need to be handled manually.
Take a look at the command “deploy_local” in the Makefile for what steps are needed

b4nst commented

Yup, I'm using fish shell so I rebuilt the function and added completion manually. Can push them somewhere here if you're interested.

I’d love that!
I do change that script sometimes, might be easier to maintain yours if it’s here as well.
Added a change default namespace feature recently for example.

@Ramilito an ARM release for M1 Macs will probably covered when kubesess will be available via brew? :)

touche @joberget, I will make it top-prio then! Hopefully this weekend 🤞

@b4nst I've included an arm target in the release now, not sure if it was precisely the one you wanted, if not please pick it out from this list
Also created an issue for that fish script if you want to add it there

@joberget Hit a road bump, need more stars on the repo to upload to homebrew apparently, created an issue about it

Closing this since the arm and fish scripts are merged (really nice code there @b4nst!) and add to brew has it's own issue

Closing this since the arm and fish scripts are merged (really nice code there @b4nst!) and add to brew has it's own issue

@Ramilito great, thanks!