RamonGebben/react-perf-tool

React Versions

Closed this issue · 3 comments

chrisblossom commented

Is this only for React v15 or can it be used with v0.14? If so, would you accept a PR to move React to the peer deps as follows:

...
  "peerDependencies": {
    "react": "^0.14.0 || ^15.0.0",
    "react-addons-perf": "^0.14.0 || ^15.0.0"
...
RamonGebben commented

@chrisblossom sure that would be acceptable. However I'm not familiar with the || operator in the version. Could you link some documentation on this subject?

As far as I know the measurements should still work for 0.14.x after the fix for #2.

chrisblossom commented

This is how reactjs/react-redux/package.json does it. https://docs.npmjs.com/misc/semver explains it in detail.

  • 😄1
RamonGebben commented

Sure make it work. Do you want to send a pull request to close the issue. Or shall I pick it up?