Rari-Capital/vaults

Issues

• ✨ Pull all or at least initial config from the factory or something

  #53 opened 3 years ago
  9

• ⚡️ lockedProfit -> unlockedProfit

  #52 opened 3 years ago
  0

• ✨ Pull all default parameters from VaultFactory

  #51 opened 3 years ago
  0

• 🔒 Provide way to force loss

  #50 opened 3 years ago
  3

• 🔒 Edge cases involving 0

  #49 opened 3 years ago
  0

• 🔒 Check strategy underlying before depositing

  #48 opened 3 years ago
  0

• 🔒 Updating lockedprofitdelay is dangerous

  #47 opened 3 years ago
  1

• 🔒 Harvest before pulling

  #46 opened 3 years ago
  2

• 🔒 Fix locked profit griefing

  #45 opened 3 years ago
  1

• ♻️ Rename harvest to poke?

  #44 opened 3 years ago
  0

• 🔒 Force report loss func?

  #43 opened 3 years ago
  1

• 🔍 Could the salt be 0 cuz constructor args would be a factor

  #42 opened 3 years ago
  2

• ♻️ Update npm description

  #41 opened 3 years ago
  0

• ♻️ Normalize withdrawal queue explanations some place like the var description are wrong

  #40 opened 3 years ago
  0

• 🐛 pullFromFloat loop will revert if it has to go thru the whole queue?

  #39 opened 3 years ago
  2

• ⚡️ SLOAD optimizations

  #38 opened 3 years ago
  0

• ♻️ Better/more consistent names

  #37 opened 3 years ago
  1

• 🔍 Possible underflow revert in exitPool

  #36 opened 3 years ago
  0

• 🔍 Require an APY function for a rebalancer module on top?

  #35 opened 3 years ago
  0

• ♻️ Can we re-order to not use checks-before-effects where possible

  #34 opened 3 years ago
  0

• ♻️ Generic function for pulling the right amount of float (used by redeem and withdraw)

  #33 opened 3 years ago
  0

• ♻️ Rename totalDeposited and totalFreeDeposited

  #32 opened 3 years ago
  0

• 🔒 Sanity checks in harvest

  #31 opened 3 years ago
  0

• ✨ Target the right amount of float in large withdrawals

  #30 opened 3 years ago
  0

• 🔍 Evaluate reentrancy risk with ERC777s

  #29 opened 3 years ago
  0

• 🔊 Events for withdrawal queue actions

  #28 opened 3 years ago
  1

• 🔒 Require cToken calls == 0

  #27 opened 3 years ago
  0

• 🔍 Can canBeHarvested be combined with balanceOfUnderlyingLastHarvest

  #26 opened 3 years ago
  0

• ✨ Separate function for manually pulling float

  #25 opened 3 years ago
  2

• ✨ ETH

  #24 opened 3 years ago
  1

• ♻️ Make use of pool/cToken consistent

  #23 opened 3 years ago
  0

• ✨ Reimplement fees

  #22 opened 3 years ago
  0

• 💥 Allow harvesting individual cTokens?

  #21 opened 3 years ago
  1

• ♻️ Rename `withdraw` to `redeem` and `withdrawUnderlying` to `withdraw`

  #20 opened 3 years ago
  0

• ✨ Support triggering harvests early

  #19 opened 3 years ago
  0

• 🔍 What happens if the cTokens drop drastically in exchange rate before a harvest?

  #18 opened 3 years ago
  1

• 📝 Ensure we clearly document that users have to be careful relying on `getVaultFromUnderlying` and not checking `isVaultDeployed`

  #17 opened 3 years ago
  0

• ✨ Set vault owner to factory owner on deploy

  #16 opened 3 years ago
  0

• ♻️ Can we refactor so that we only need underlying funcs on ctokens and not balanceOf(), etc?

  #15 opened 3 years ago
  0

• ✅ Write tests to ensure the system handles losses properly

  #14 opened 3 years ago
  2

• ⚡️ Remove as many loops as possible (especially nested ones)

  #13 opened 3 years ago
  0

• 🔒 Validate all admin config options like fees

  #12 opened 3 years ago
  0

• ⬆️ Upstream Bytes32AddressLib to Solmate

  #11 opened 3 years ago
  0

• ♻️ Be explicit instead of `using for *`

  #10 opened 3 years ago
  0

• ✨ Add getter functions for public array vars

  #9 opened 3 years ago
  0

• 👷‍♂️ Lower optimizer runs to 1,000,000

  #8 opened 3 years ago
  0