RasaHQ/paraphraser

Comments on the Docker setup guide

Opened this issue · 5 comments

tttthomasssss commented

Some things I have encountered during setup

  • I know this is an obvious step but it might be worthwhile mentioning that the repository needs to be cloned and the Dockerfiles later used in the setup are contained therein
  • Might be worth including a link to a docker installation page
  • There was a missing path information in the docker build commands, i.e. it needs the path to the Dockerfile at the end of the command as in docker -f Dockerfile.cpu -t paraphraser_cpu:latest <path/to/dockerfile>. In the simplest case where the docker file is in the current directory it becomes docker -f Dockerfile.cpu -t paraphraser_cpu:latest .
  • The paraphraser run command has --language as a mandatory arg which needs to be added to the example commands
  • Interactive mode didn't work for me locally, though no idea why
  • Its not immediately clear whether the --gpus all flag is a docker arg or a paraphraser arg (might be worth seplling out the whole command for clarity - also b/c of the paraphraser_gpu:latest arg; I'd assume most/many people will just copy/paste the commands)
  • The command format around specifying the path for the input_file in bulk mode is a bit unwieldy.
dakshvar22 commented

There was a missing path information in the docker build commands, i.e. it needs the path to the Dockerfile at the end of the command as in docker -f Dockerfile.cpu -t paraphraser_cpu:latest <path/to/dockerfile>.

@tttthomasssss The path to Dockerfile is given after -f option in the command. Is there anything else you mean?

tttthomasssss commented

Yes, so when I tried to run this - even within the repository - Docker complained about not finding Dockerfile.cpu. I then figured out that the path information for the dockerfile needs to go at the end of the command. Even when running within the repo I had to append . in order to make it work.

dakshvar22 commented

That seems strange. I just tried that command and it works. What version of docker were you using?

tttthomasssss commented

Maybe my local setup is just a mess 🙈 . Docker version 20.10.2, build 2291f61

federicotdn commented

I also needed to add . at the end to make it work!