RasaHQ/rasa-train-test-gha

Assumed working directory as /app?

bml1g12 opened this issue · 4 comments

Is it correct that this repository implicitly assumes that your docker image has a working directory of /app?

I am aware I can set the path to the rasa folder via workspace - but it still seems to assume that when we start the train/validate/test commands, this code will be located in /app

echo DOCKER_ARGS="--rm --tmpfs ${{ inputs.tmpfs_directory }} -e HOME=/app -e MPLCONFIGDIR=/tmp/.mplconfigdir \

Thanks for the issue, @JustinaPetr will get back to you about it soon!

You may find help in the docs and the forum, too 🤗

The action mounts workspace to /app because all Rasa docker image assumes /app as the default working directory. You can see it here: https://github.com/RasaHQ/rasa/blob/main/docker/Dockerfile.full#L52

Have you encountered any problems with it or do you have any idea for a better approach?

Thanks for your comment. It took me a while to realise that this was the issue when making a custom image.

I think a nice improvement here would just be to just add a step which asserts that /app is the entrypoint, or if that's ugly, maybe just documenting in the README that this Action requires your entrpoint to be /app

🙇