[Feature request] or [Bug] Navbar stays expanded when changing pages on Mobile

Not sure if this is a bug or feature, but when I browse the RaspAP WebUI on mobile, the navigation bar stays expanded when I switch between pages, and I have to close it when the target page loads. It seems it should close after switching pages, as it's a pop-over bar, as opposed to a side-menu that is part of the page, and it obfuscates the page and being able to do anything on it.

This is probably the default behavior of SB Admin 2 which RaspAP implements. Maybe try their demo and see if you observe the same?

In the SBAdmin Live Preview, the navigation menu doesn't show:

But when you click the "hamburger" icon, it shows, but as part of the page, as opposed to over the page:

In RaspAP, you see the navigation menu overlays the page:

Yeah, our left nav is quite a bit different. The wider logo + LED indicator block prevents it from sharing the main content panel. Maybe this could collapse on smaller screen sizes, not sure how else to deal with it.

It's not the overlaying that's the "problem" (more of an minor annoyance than problem), it's that it persists when you change pages, and have to click the "hamburger" icon to collapse it when the new page loads.

I see what you mean. There's quite a bit going on elsewhere in the project at the moment. If you're comfortable with Bootstrap / frontend dev perhaps open a PR?

With SB Admin or RaspAP?

With this project :) I'm also glad to contribute

I'll see what I can do

Looks like it's just commenting out these lines (tested locally, works as expected, just requires clearing browser/tab cache). I can create a PR if you still want?

raspap-webgui/dist/sb-admin/js/scripts.js

Lines 15 to 18 in 2f9a2df

    
           // Uncomment below to persist sidebar toggle between refreshes 
        
           if (localStorage.getItem('sb|sidebar-toggle') === 'true') { 
        
               document.body.classList.toggle('sb-sidenav-toggled'); 
        
           }

Good catch. Feel free to open a PR that comments this out. You can also copy code from this PR to prevent caching, if you like (completely optional).

Hopefully I did that ^ right?

Perfectly, yes :)

Resolved in #1914 @ruralmeltdown many thanks

	// Uncomment below to persist sidebar toggle between refreshes
	if (localStorage.getItem('sb\|sidebar-toggle') === 'true') {
	document.body.classList.toggle('sb-sidenav-toggled');
	}