feat: Show added patches next to deleted patches
Closed this issue · 4 comments
Feature description
Show patches that were added in the dialog where it shows that patches have been deleted.
Motivation
The issue is that it does not show that patches were added at the same time. The issue is that Manager can not distinguish between deleted and renamed patches, so a rename is a delete & add at the same time, whereas the old name was deleted and the new name was added.
Acknowledgements
- I have checked all open and closed feature requests and this is not a duplicate.
- I have chosen an appropriate title.
- The feature request is only related to ReVanced Manager.
Show all the new patches or only the new patches that the user has selected?
The dialog should show the patches that were removed, but also show all the new patches added (regardless if the user included the new patches or not).
So the warning dialog would not be a warning but instead a "hey some patches were removed, but also some patches were also added".
It will solve the issue of patches being renamed and users losing their mind thinking the patch is no more.
Just to clarify, the dialog shows for the situations of:
-
Patches were removed, and no new patches are available since the last time the app was patched (no major code changes needed, and the existing 'warning' dialog should show).
-
Patches were removed, and at least 1 new patch is available since the last time the app was patched (Show a non warning dialog, informing both patches were removed but new patches are now available).
The dialog should not show if new patches are available and no existing patches were removed.
@oSumAtrIX implemented in #2257
You should close this issue.