ReactionMechanismGenerator/RMG-database

Duplicate reaction families? Surface_Dual_Adsorption_vdW and Surface_Abstraction_Beta_double_vdW

rwest opened this issue · 4 comments

rwest commented

I think that this reaction 17840f17-2da8-457c-89c3-8c72305760bf matches the family Surface_Dual_Adsorption_vdW
[<Entry index=23 label="C=C">, <Entry index=55 label="C-R">]
new
where R4-R6 are a C-H (note that I am using the proposed corrected chemdraw picture, see #630 )

but its reverse reaction 088c5730-5828-4da6-88b0-2de8840031cc matches Surface_Abstraction_Beta_double_vdW
[<Entry index=3 label="C-H">, <Entry index=2 label="Adsorbate1">]
Surface_Abstraction_Beta_double_vdW

The Surface_Dual_Adsorption_vdW family was added in #385 (specifically commit 8f63ed8)

The Surface_Abstraction_Beta_double_vdW family was added in #521

Both additions seem to use this example reaction: COOH* + OH* <=> CO2* + H2O*

We should resolve this duplication (consolidate any useful data and remove one family)
and should implement database tests to detect and prevent other inadvertent duplication.

I created the Surface_Abstraction_Beta_double_vdW family because we have BEP relations from the literature for this direction. The Surface_Dual_Adsorption_vdW family is just based on one training reaction. I trust the results from the Surface_Abstraction_Beta_double_vdW more and never used Surface_Dual_Adsorption_vdW. Therefore, I would suggest to remove Surface_Dual_Adsorption_vdW.

rwest commented

Thanks Bjarne.
The plot thickens...
Some reactions are matching both Surface_Abstraction_Beta_double_vdW AND Surface_Dual_Adsorption_vdW like
ca38f7c2-69c0-43f9-9e2b-b6bae69b8e5e
327e970a-f30a-4eab-90ea-bacf33d6304b
59217589-4682-44bf-96d9-4955f99fb0aa
89a19cc6-3b1e-4988-890d-065ad91a69c4

But some reactions are matching only Surface_Dual_Adsorption_vdW like
9fd25f2a-e61e-401d-b2a8-804641fe296b
8be58d17-33e4-4527-89ec-cacf368f6596
84cd231d-c867-4075-a68f-8c731176615c
d6859730-3942-4eee-afeb-9227a666bb99

Can these reactions occur? (they do show up in Magraf's list). If so, should/can we modify Surface_Abstraction_Beta_double_vdW so that it matches/generates them?

for the first reaction, the "abstracting" is R!H so it's disallowed. H is technically abstracting the methyl group.

1 *6 Xo  u0 {2,S}
2 *4 R!H u0 px cx {1,S}	

Second, third, and fourth, in the "donating" group, we have a double bond between *1 and *2 in the donating group. we don't allow a double bond to move to a triple.

1 *1 R!H u0 px cx {2,S} {4,S}
2 *2 R!H u0 px cx {1,S} {3,S}
3 *3 R   u0 {2,S}
4 *5 Xo  u0 {1,S}

In general, maybe we could make this family more permissive? I am not sure if that is opening us up for more junk kinetics but we should probably err on the side of allowing more.

I think we can make the Surface_Abstraction_Beta_double_vdW family more permissive. However, an H atom shouldn't be able to abstract a CH3 group, but the other reactions are reasonable (although very funky). I think we should allow double bonds between 1 and 2. I'm going to update the PR.