Reactive-Extensions/rxjs-jquery

Wrong object passed to onNext for some functions

midnite8177 opened this issue · 2 comments

Looking at the source of rx.jquery.js there is intention of passing the jQuery object through the observable when it triggers, but there is some mismanagement of 'this' causing it to be the DOM element passed through and not the intended and expected jQuery object.

handeAnimation (note the misspelling) should be passing jQueryProto to the subject.onNext call, and not 'this'

proto.animateAsObservable should capture 'this' to a local and that local passed to the subject.onNext call inside the complete callback.

proto.fadeToAsObservable should do the same thing as above

Fixed as per 1.1.5

Shouldn't proto be passed to onNext in of 'animateAsObservable' also?