Use uniform spacing and (LF-only) line endings

Question

Closed this issue 8 years ago · 9 comments

RFG uses a mix of spaces, tabs, LF, and CR+LF line separators:

browser.config.xml is CRL+LF-separated. Arguably this is because it targets Windows, but the file likely won't be edited on Windows, and there are other text files in the package that Notepad will display in one lines. The XML uses spaces for indentation - great.
manifest.json uses LF-only line separators, but tabs instead of spaces for indentation
safari-pinned-tab uses LF line endings and wraps at 74 chars/line.

Answer 1 · 2016-10-06T09:07:26.000Z

Thanks. I never realized this.

So:

manifest.json looks okay. This is what json_encode and JSON_PRETTY_PRINT generate so I rather stick to it.
browserconfig.xml: let's switch to LF-only and tabs, to match manifest.json. Plus it's (a little bit) more compact.
Safari pinned tabs SVG icon: SVGO will decide, see #261.

Answer 2 · 2016-11-03T15:06:57.000Z

Fixed in branch package_v0_14

Answer 3 · 2017-01-18T08:31:56.000Z

Deployed a minute ago.

Answer 4 · 2017-01-18T17:04:23.000Z

@phbernard: nitpicking but manifest.json does not have the end of file line break like the browserconfig.xml has. :)

Answer 5 · 2017-01-18T18:35:23.000Z

Hex editor speaking :) Both manifest.json and browserconfig.xml have UNIX-style (ie. 0x0A) end of line.

Do you observe something else?

Answer 6 · 2017-01-18T18:37:04.000Z

Yeah. I tried it 3 times and the result is the same. The manifest doesn't have the end of file line break while the xml does :)

On Jan 18, 2017 20:35, "Philippe Bernard" ***@***.***> wrote: Hex editor speaking :) Both manifest.json and browserconfig.xml have UNIX-style (ie. 0x0A) end of line. Do you observe something else? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#283 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVVtTQtKktyUyjE035UPNbNzmOJ5A5Lks5rTltsgaJpZM4KOVD-> .

Answer 7 · 2017-01-19T08:08:14.000Z

I've just tested it again. I clearly see 0x0a everywhere (and not 0x0d0a):

JSON

XML

Could you tell me how you check the end of line?

Answer 8 · 2017-01-19T08:13:09.000Z

It's obvious for me just by opening the files...

See the attached images.

As you can see manifest.json doesn't have the end of file line break.

Answer 9 · 2017-01-19T09:12:39.000Z

Oh, okay! The final line break at the end of the file! Sorry, I misread your first message, I thought you were talking about all ends of line.

I consider this as another issue, although it would have been good to fix everything at once. I just entered #304