RealFaviconGenerator/realfavicongenerator

androidChrome section, using existingManifest doesn't carry over name and short_name

Opened this issue · 0 comments

If the androidChrome section includes a manifest section and this section includes:

    name: 'App Name',

Then the generated site.webmanifest, will include:

    "name": "App Name",
    "short_name": "App Name",

But if the manifest section also specifies an existing manifest, e.g.:

    name: 'App Name',
    existingManifest: { description: 'App Description' },

Then the "name" and "short_name" will not be included in the generated site.webmanifest (no matter the value of onConflict), and only the description will be added, e.g.:

    "description": "App Description",

Based on the parameter settings, it would make more sense if the generated manifest would include:

    "name": "App Name",
    "short_name": "App Name",
    "description": "App Description",

The workaround, for the androidChrome section, is to include also name and short name in existingManifest, e.g.:

    existingManifest: { name: 'App Name', short_name: 'App Short Name', description: 'App Description' },

PS! Thanks for a great generator