RedHatDemos/SecurityDemos

Issues in NBDE, USBGuard, GPG

Closed this issue · 5 comments

It's mostly nitpicks, but anyway:

NBDE

  • sometimes LUKs is used, instead of full capitalization

USBGuard

  • 'he/she' can be changed to 'they'
  • the preconfiguration notes are a bit unclear, as there is "preliminary knowledge" section. It's still just FYI (you are not supposed to act on that), but it confused me a bit. I was not sure, if I am supposed to create those XML files or not

GPG

  • what is referenced as "user ID" is "Real Name" in CLI
  • '(O) for Okay' is just fine, instead of 'Okay/Quit'
  • "comment" is before OK, so switch those lines

I change User ID to Real Name in the GPG doc. Good catch, thanks.

@dahaic is this sufficient? #171

Thank you @dkopecek ! Looks good to me.

Thank you @dkopecek ! Looks good to me.

Ok, thanks for review!