for PRs, allow only squash or rebase, and demand testing to be passed?

Question

for PRs, allow only squash or rebase, and demand testing to be passed?

Closed this issue 7 years ago · 9 comments

favonia commented 7 years ago

Now GitHub provides fine-grained controls over the operations available to PRs.... @jonsterling

Answer 1 · 2018-02-08T19:47:41.000Z

Sure, that seems reasonable!

Answer 2 · 2018-02-09T00:54:40.000Z

I've switched it so that you can only do squash or rebase; do you know how to make it so that tests have to pass?

Answer 3 · 2018-02-09T02:43:45.000Z

https://help.github.com/articles/enabling-required-status-checks/

Answer 4 · 2018-02-09T02:45:14.000Z

We can even demand reviews if we want to.

Answer 5 · 2018-02-09T14:19:47.000Z

I've turned on basically the most draconian set of restrictions for master so we can try them out 😄 If it seems too much, we can make adjustments. I made it so that reviews are required, tests passing are required, and I think I made it so that we can't even push directly to master without going through a PR (I hope that's what this setting did, not sure--we'll find out).

Answer 6 · 2018-02-09T15:05:44.000Z

Closed as fulfilled.

Answer 7 · 2018-02-09T21:45:28.000Z

@jonsterling I think you are the only one who can merge PRs now. At least I can't. Probably too restricted?

Answer 8 · 2018-02-09T21:46:34.000Z

oh no!! I guess I messed up the settings... let me fix it when i get back to a computer

…

On Feb 9, 2018, at 4:45 PM, favonia ***@***.***> wrote: @jonsterling I think you are the only one who can merge PRs now. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Answer 9 · 2018-02-10T20:45:28.000Z

I think I have fixed it.