RehanSaeed/Serilog.Exceptions

Entity Framework Logging Behaviour

statler opened this issue · 2 comments

Describe the bug

The docs describe the known issue with logging of the whole database as below:

WARNING: In older versions of Serilog.Exceptions, if you are using EntityFrameworkCore with Serilog.Exceptions you must add this, otherwise in certain cases your entire database will be logged! This is because the exceptions in Entity Framework Core have properties that link to the entire database schema in them (See #100, dotnet/efcore#15214). Newer versions of Serilog.Exceptions avoids this issue by preventing the destructure of properties that implement IQueryable preventing their execution.

In older versions of Serilog.Exceptions Can you please clarify what versions this is necessary for. 'Older versions' is not definitive or informative. Is it still a requirement or not.

Steps to reproduce

View the docs

Expected behaviour

The requirement for what versions the additional library is required for should be explicit, or at least definitive about whether the issue is present in the current build.

This was the PR that had the fix in it:

This made it into the 8.0.0 release:

Documentation updated.