Update `installModels` to go through the v2 API endpoints
Opened this issue · 2 comments
rai-sdk-javascript/src/api/model/modelApi.ts
Lines 26 to 41 in fdbf90d
It's currently using the v1 actions API. It should instead be issuing an exec() query that loads the models, similar to this implementation of load_json in the julia SDK:
https://github.com/RelationalAI/rai-sdk-julia/blob/6c9ddf55fe791d82b15c8a9e9f80c0bcdec04064/src/api.jl#L650-L655
Ideally it should construct a query string + inputs, that would look something like either of these options:
query = `def insert:rel:catalog:model = model_insertions`;
inputs = {
name: "model_insertions",
value: models.map((m, index) => {
[m.name, m.value],
})
};or like this (copied from the current Console code):
models.forEach((m, index) => {
const inputRelation = `__model_value__${index}__`;
queryStrings.push(
`def delete:rel:catalog:model["${m.name}"] = rel:catalog:model["${m.name}"]`,
`def insert:rel:catalog:model["${m.name}"] = ${inputRelation}`,
);
queryInputs.push({
name: inputRelation,
value: m.value,
});
});@denisgursky I've assigned this one to you, and put it at medium priority. It would be great to have this converted so that we can see a dent in our v1 vs v2 numbers 😭
Note: This issue has been migrated to https://relationalai.atlassian.net/browse/RAI-6246.
This link is only accessible to employees of RelationalAI.