RenderKit/openpgl

noisy stdout

Opened this issue · 3 comments

when rendering anything in blender (which uses openpgl), the stdout of blender gets cluttered with millions of 'scateredContribution'. this comes from

std::cout << "scateredContribution" << std::endl;

is there hidden effect this has that i'm not seeing, or is this just a debug print that was left in? it spams a very large number of lines and doesn't really mean anything

given that the other debug prints are all either commented out, or behind #ifdef OPENPGL_SHOW_PRINT_OUTS or OPENPGL_DEBUG_MODE (other than the ERROR: ones), i guess this one was just an accident

@nekopsykose
Thanks for reporting the issue. It will be fixed in the next release.
Could you share the blender file of your scene so that we can check why this is triggered in the first place.

Cheers,

Sebastian

i don't actually remember how to reproduce this, probably relies on path tracing + cycles being enabled in render options and then happened in any scene on f12-render on older blender. i can't reproduce anymore probably because that path might just not be hit with newer blender versions

the debug print should definitely be in an ifdef like the others though and that would prevent it from happening ever :)