Throw std::runtime_error instead of const char *

Question

Throw std::runtime_error instead of const char *

egorpugin opened this issue 4 years ago · 3 comments

https://github.com/ReneNyffenegger/cpp-base64/blob/master/base64.cpp#L63

This line will not be catched by catch (std::exception), only catch (...).
(Of course it will be catched by catch (const char *), but this is not what users write.

Probably it should be replaced with std::runtime_error.

Answer 1 · 2020-10-23T17:06:01.000Z

Agreed, I have run into this exact error, and would prefer if an std::exception was thrown.

Answer 2 · 2020-10-23T20:35:54.000Z

The function now throws std:runtime_error(...).

Answer 3 · 2020-10-24T00:19:39.000Z

@ReneNyffenegger
Hi,

Could you use https://semver.org/ later for publishing releases?
Like using 3 number tags 2.0.0 or v2.0.0 etc.