ResidentMario/missingno

should geopandas be listed in setup.py?

suliuzh opened this issue · 1 comments

Hi
As we can see, geopandas is used as dependency in source code as a must. But when I use "pip install missingno", it seems geopandas is not installed automatically. So I am wondering if geopandas should be listed explicitly in setup.py?
image

It's not actually a requirement, just a peer dependency of the following (deprecated) method:

def geoplot(df,
            filter=None, n=0, p=0,
            x=None, y=None, figsize=(25, 10), inline=False,
            by=None, cmap='YlGn', **kwargs):
    warnings.warn(
        "The 'geoplot' function has been deprecated, and will be removed in a future version "
        "of missingno. The 'geoplot' package has an example recipe for a more full-featured "
        "geospatial nullity plot: "
        "https://residentmario.github.io/geoplot/gallery/plot_san_francisco_trees.html"
    )
    try:
        import geoplot as gplt
    except ImportError:
        raise ImportError("Install geoplot <= 0.2.4 (the package) for geoplot function support")

    if gplt.__version__ >= "0.3.0":
        raise ImportError(
            "The missingno geoplot function requires geoplot package version 0.2.4 or lower." 
            "To use the geoplot function, downgrade to an older version of the geoplot package."
        )

    import geopandas as gpd
    from shapely.geometry import Point