ResidentMario/missingno

MatplotlibDeprecationWarning - grid(b=False) -> grid(visible=False)

r-leyshon opened this issue · 3 comments

Running pytest results in:

MatplotlibDeprecationWarning: The 'b' parameter of grid() has been renamed 'visible' since Matplotlib 3.5; support for the old name will be dropped two minor releases later.
ax0.grid(b=False)

Matplotlib 3.7 has been released now and has dropped the 'b' parameter as @r-leyshon mentioned it would above. This is now causing errors instead of deprecation warnings:

Snag_b5bdcd29

To confirm @sernst observation, now missingno breaks my build checks if I do not pin matplotlib to 3.5.0.

Please consider the PR I raised. It should be a one liner to fix I think. Link to the breaking change in matplotlib changelog

ale-dg commented

Hi all,

Just a quick FYI, I have installed the library now through conda (condo-forge) and the issue is still built in that distribution. It is not a big issue to solve if one is familiar with matplotlitb, though it might open an issue if someone is not so familiar with working it around.

Best