ResponsiveBP/Responsive

Modal not working on Firefox

stebogit opened this issue · 2 comments

Hi,
I found that the Modal feature (I'm only using that part of the library) doesn't work on Firefox (v57.0b5 (64-bit)) due to this non-standard line of the stylesheet, which embraces the css handling the hiding/showing of the modal layer:

@media (-webkit-min-device-pixel-ratio: 0) { 
    ...
}

Surprised nobody encountered the same issue so far.

However, I removed that line and it seems to work just fine.

Hi @stebogit,

Thanks for raising this, in answer to your statement:

Surprised nobody encountered the same issue so far.

I would say that is probably because they are not using a beta release.

The non-standard code you are seeing is a hack to specifically filter out Webkit browsers and will affect select inputs.

@media (-webkit-min-device-pixel-ratio:0) {

In the latest stable this appears to be fine.

modal-firefox

I'd like to see what happens when a final v57 release is out since I believe they have updated the parsing engine for that.

Let's keep this open and track what happens.

Cheers

James

Confirmed to be working perfectly in Firefox 57 64bit. I'm not sure what the cause of your issue is but it's not the default CSS.

modal-firefox