RestComm/Restcomm-Connect

Shell scripts does not support self-closing XML at SMTP

Closed this issue · 1 comments

Is this a BUG REPORT or FEATURE REQUEST?:

bug

What happened:

Shell configuration script does not support self-closing XML elements at SMTP configuration.

e.g. The following XML segment will be ignored by config-utelsil.sh, as the sed regular expression matches only with <element>.*</element>:

  <smtp-service>
    <host/>
    <user/>
    <password/>
    <port/>
  </smtp-service>

What you expected to happen:

SMTP configuration performed normally, leaving all XML elements with the values informed at advanced.conf

How to reproduce it (as minimally and precisely as possible):

  • Download latest Restcomm (Telscale);
  • Configure restcomm.conf and advanced.conf;
  • Start restcomm;
  • Check the file WEB-INF/conf/restcomm.xml.

Anything else we need to know?:

It seems that self-closing XML elements are being delivered by default in restcomm.xml with the releases. Not sure if relevant, but maybe all scripts with sed command should support this format.

Environment:

  • Restcomm Connect version (from startup logs): 8.4.0-174
  • Cloud provider or hardware configuration: MacBook Pro
  • OS (e.g. from /etc/os-release): OSX
  • Kernel (e.g. uname -a): Darwin Kernel Version 17.7.0
  • Deployment method (e.g. docker-compose, with linked docker-compose.yml file,
    or application server info + deployment option): Standalone JBoss-AS7
  • Others: N/A

Fixed via #3000