RevivalPMMP/PureEntitiesX

Entities jump as far as needed to jump over a wall

Closed this issue · 30 comments

Sandertv commented

Spawned entities can not jump on 1 block high walls. Slabs and stairs are fine, but full blocks do not work at all.

Magicode1 commented

That's a problem. The only time I have seen them be able to hop a 1 block was when a pig glitched 20 blocks into the air :)

Sandertv commented

Yep. Hitting them allows them to get up blocks too.

Sandertv commented

Changed title, we gotta fix this issue now :P

tjespe commented

@Sandertv @Skull3x Comitted a change 27 minutes ago which seems to have fixed it. However it looks like the entities jumps higher than necessary. This isn't really a big problem though.

jdot-r commented

@Sandertv @tjespe Entities jump as far as needed to jump over a wall.

A wall at a specific height? Or a wall in general??

tjespe commented

The original issue was that entities were unable to "jump on 1 block high walls" so I guess a wall with 1 block height is what we're talking about. Which seems to have been fixed by your commit @Skull3x

jdot-r commented

@tjespe Not necessarily, my commit implements jumps but for walls higher than the entity. It tends to do something known as wall walking, similar to the Vanilla Spider. Due to:

$this->motionY = 0.7;

I have not added anything to prevent that yet as of now

Sandertv commented

Yep. That's what we got left to do.

jdot-r commented

@tjespe @Sandertv I will work on that now or in the future if not implemented sooner :)

tjespe commented

As of now, all entities jump right over fences which kind of ruins farming and stuff

  • 😄3
Sandertv commented

@Skull3x we could fix this issue easily by checking if the entity is on the ground or not, or we could just not make the entity jump if the wall is higher than 1 block. Which one do you think is better?

jdot-r commented

@Sandertv I like the 1st option better

jdot-r commented

@Sandertv Unless you plan on removing jump capabilities, I'm fine either way 👍

Sandertv commented

Alright, let's go for the first one then :) Let's not forget to make it so spiders DO keep this capability of wall climbing.

tjespe commented

I also think the 1st option is best becuase in "real minecraft" the animals will always try to jump over fences and stuff even though they can't.

tjespe commented

One thing you should keep in mind (although it's not super important) is that spiders should be able to wall walking and climb even though they're not on the ground

jdot-r commented

Yes, I agree. I will attempt to help make this as similar to Vanilla as possible

  • 👍2
tjespe commented

At least the entities don't drown anymore, which is another issue

Sandertv commented

They don't? Do they stay on the surface now?

tjespe commented

I'm sorry, they do drown some times. It depends on whether or not there are any solid blocks around them, so when they go in to a small water they survive but when they go out in the sea they wuickly go to the bottom, as they did before.
It's an improvement anyway though, considering that they used to always die when they go into water, but it's not fixed.

jdot-r commented

@tjespe @Sandertv Yes, I will add swimming functions if they have not been added already right now. And could one or both of you check the gitter chat? :)

Sandertv commented

Oh of course! Sorry :P

Deleted user commented

Is this fixt?

Sandertv commented

No, I'll leave this up to @Skull3x

Sandertv commented

Bump @Skull3x, could you have a try to fix this?

Magicode1 commented

If he hasn't, we can get it done tomorrow.

Deleted user commented

@kniffo80 Please you can fix that? Is very important feature.

kniffo80 commented

Puh, I'm not that good in maths 😄 but i can give it a try. It's already on my list for the things next to be done.

kniffo80 commented

This can be closed - as i think this is solved now in latest kniffo80-dev ...