Reya-Labs/voltz-core

Clear all the warning and Dependabot alerts

Closed this issue · 2 comments

Need to figure out the cause of all the warnings we get post compilation and how they can be resolved. Also, there seem to be quite a few warnings from the dependabot, think worth checking and resolving these ahead of the testnet launch.

On at lest one occasion n the past I found it impossible to eliminate all solidity compiler warnings, and at that time there was no way to silence them which was a source of frustration for me. But it's been a while since I tried so I don't know the latest status - hopefully they have introduced a way to silence them.

Just mentioning it so @zskolnik doesn't spend a whole day looking for a solution to what might be an impossible problem.

In the long term I'd also be in favour of eliminating warnings from linting and solhint, by mandating zero warnings where we currently mandate zero errors. But that's very low priority.

Agreed, thanks @CyclopsRex. Would follow 80/20 principle and try to remove the obvious warnings and move on so it doesn't take too much time.