Remove !(((amount0 <= 0 && amount1 >= 0) || (amount0 >= 0 && amount1 <= 0)) || (amount0 == 0 && amount1 == 0)) in FixedAndVariableMath.

Question

Remove !(((amount0 <= 0 && amount1 >= 0) || (amount0 >= 0 && amount1 <= 0)) || (amount0 == 0 && amount1 == 0)) in FixedAndVariableMath.

Closed this issue 3 years ago · 2 comments

!(((amount0 <= 0 && amount1 >= 0) ||
(amount0 >= 0 && amount1 <= 0)) ||
(amount0 == 0 && amount1 == 0))

Instead we should just return 0 if (amount0 == 0 && amount1 == 0)) and else let the code run.

Answer 1 · 2022-03-14T16:11:05.000Z

Ref: https://github.com/Voltz-Protocol/voltz-core/blob/1198172da2d8d924cfeee1915d24de38579a0bdb/contracts/core_libraries/FixedAndVariableMath.sol#L202

Answer 2 · 2022-03-14T16:12:25.000Z

Comment from ABDK: "don't see any good reason to forbid both position amounts to have the same sign, other than this would make the code a bit more complicated, If both are zero, it is fine. But if both a marginally positive, then the current implementation will revert for no good reason."