RhoInc/Webcharts

Add a workaround for Webcharts All subsetter logic.

samussiah opened this issue · 4 comments

If the filter variable has a value of All Webcharts counts All twice.

Test notes

  • Verify that if All appears in a variable underlying a filter, it also appears as an option in the filter dropdown separate from the default All option:
    • Choose a renderer with a default All filter: ae-timelines, crf-heat-map, participant-visit-listing, or clinical-timelines.
    • Download the data file.
    • Add a value of All to one of the All filter columns.
    • Upload the modified data file.
    • Render the chart and verify the filter contains two All options, one that selects all data and one that selects only the modified record.

@samussiah Is there an easy fix for this? If so, shall we address along with #238 in v1.11.3?

Webcharts has logic here that doesn't allow a value of All in the data to filter correctly. It's an edge case and one that can be avoided by replacing All with a different value (Overall, All Records, etc.). More difficult to fix than I figured.

issue logged to address All subsetter logic in ae-timelines

It works mostly. There is an edge case where updating a field to All can error CRF, CT and PVL. Spencer is aware and there are issues opened for those 3 renderers.