Add a workaround for Webcharts All subsetter logic.

Question

Add a workaround for Webcharts All subsetter logic.

Closed this issue 5 years ago · 4 comments

samussiah commented 6 years ago

If the filter variable has a value of All Webcharts counts All twice.

Test notes

Verify that if All appears in a variable underlying a filter, it also appears as an option in the filter dropdown separate from the default All option:
- Choose a renderer with a default All filter: ae-timelines, crf-heat-map, participant-visit-listing, or clinical-timelines.
- Download the data file.
- Add a value of All to one of the All filter columns.
- Upload the modified data file.
- Render the chart and verify the filter contains two All options, one that selects all data and one that selects only the modified record.

Answer 1 · 2019-02-27T18:53:33.000Z

@samussiah Is there an easy fix for this? If so, shall we address along with #238 in v1.11.3?

Answer 2 · 2019-02-28T23:03:06.000Z

Webcharts has logic here that doesn't allow a value of All in the data to filter correctly. It's an edge case and one that can be avoided by replacing All with a different value (Overall, All Records, etc.). More difficult to fix than I figured.

Answer 3 · 2019-03-25T14:34:42.000Z

issue logged to address All subsetter logic in ae-timelines

Answer 4 · 2019-03-25T18:22:20.000Z

It works mostly. There is an edge case where updating a field to All can error CRF, CT and PVL. Spencer is aware and there are issues opened for those 3 renderers.