Rich-Harris/svelte-cubed

SC.Primitive does not support castShadow

renefournier opened this issue · 7 comments

Myrmod commented

I added the missing properties in a branch of mine: https://github.com/Myrmod/svelte-cubed/tree/add-missing-properties-to-objects

Would this solve your issue as well? Does someone know if there is a reason why this wasn't added directly?

renefournier commented

This looks great. Maybe Rich was just busy with stuff. Things get missed. I miss stuff all the time. PR?

renefournier commented

Hmm, add your code to my repo... still no shadows.

renefournier commented

Does it work for you?

Myrmod commented

Can you show me the code of the SC.Primitive the way you want it to work? I am by no means an expert on ThreeJS though :D

renefournier commented

Hi @Myrmod Here's my code: https://bitbucket.org/renefournier/renefournier.com/src/main/app/src/routes/index.svelte You can see it running here: https://renefournier.com/ (I went into /node_modules/svelte-cubed/components/objects/Primitive.svelte and addded your lines) but to no effect. And, like you, my experience with Three JS is only a few days, and not directly, but through @Rich-Harris’s library, which means I may be “holding it wrong”, as they say. It would be nice if we can sort this out. Ping me if you find or think of anything.

Myrmod commented

@renefournier I made a working example in #41