RichiH/vcsh

"vcsh which" parameter check broken

Closed this issue · 4 comments

As discussed on IRC, since d946b07 vcsh which no longer accepts a substring as documented but expects the full path to a file that exists in the work tree.
The correct way to determine the exit code would probably be to remember if grep ever returned 0 (matched anything).

sed is part of POSIX so the new external dependency is fine.

I really dislike that we would need another tempfile. I like the substring part, though.

All in all, wouldn't it be more versatile to see if there's any output from the loop and error out if that output is empty?

@tribut : I just cherry-picked your b3d7fb3 and I think I will merge 9cf8f5c into master unless you object.

Seems fine.

Thanks :)