"vcsh which" parameter check broken
Closed this issue · 4 comments
tribut commented
As discussed on IRC, since d946b07 vcsh which
no longer accepts a substring as documented but expects the full path to a file that exists in the work tree.
The correct way to determine the exit code would probably be to remember if grep
ever returned 0 (matched anything).
RichiH commented
sed
is part of POSIX so the new external dependency is fine.
I really dislike that we would need another tempfile. I like the substring part, though.
All in all, wouldn't it be more versatile to see if there's any output from the loop and error out if that output is empty?
RichiH commented
tribut commented
Seems fine.
RichiH commented
Thanks :)