`install -D` is not portable
carlocab opened this issue · 8 comments
d799fe1 changed the mkdir
and install
calls to install -D
, but this flag is not portable. In particular, this leads to build failure on macOS (and, presumably, anywhere else that uses BSD install
).
Oh bother and confound it all, half the point of some of my overhauls has been to improve portability, so sorry about this regression. Sometimes GNU syntax is just so temptingly BETTER! I'll try to get some CI running (perhaps on Cirrus BSD runners) so we're actually testing BSD installs on every commit.
Since you're already using GitHub actions, you can also run your build on macOS CI. It should be as simple as adding macos-latest
here:
vcsh/.github/workflows/build.yml
Line 8 in 9a2bce5
You'll probably need something like
matrix:
os: [ubuntu-latest, macos-latest]
runs-on: ${{ matrix.os }}
but I'm no expert on GitHub actions.
Can you confirm if 2.0.4 builds for you, please?
Thanks! I'll give it a try.
The new release works great. Thank you.
@carlocab thanks for reporting & checking!
Do you want to submit a PR for the build system?
I've still got a lot of work at Homebrew (new macOS version just dropped), but ping me in about two weeks and I'll try and help you out with that :)
I will leave it open then and try to set a reminder for myself to poke you. :)