RidersDiscountCom/HypChat

Rewrite Saving

AstraLuma opened this issue · 4 comments

It has become my observation that saving in HipChat is the exception, not the norm. And in many cases, you can't just PUT the modified results of a GET and expect it to work.

However, HypChat assumes that this is the case and that exceptions will be changed eventually.

It might be time to revamp how saving is handled to better reflect reality.

I noticed an exception on a room save yesterday. I've added a room specific save method that eliminated the error on my side. It's working for me. Take a look.

... it'll work for now. I'd still rather have a declarative system for defining what to save.

I'm open to pull requests. As you know Python isn't my strongest language, so I try to keep it simple.

Yup. In my copious free time.