RillingDev/yugioh-deck-tool

Re-evaluate handling of decks in URI

Closed this issue · 9 comments

RillingDev commented

As suggested:

  • remove compression of shareable link, as it provides very little actual advantage
  • instead use YDKe-like encoding, to improve cross-application functionality
kevinlul commented

Suggestion: ydke=main!extra!side!name. This URL parameter and format will be shimmed by DawnbrandBots/deck-transfer-for-master-duel#8 for the time being.

kevinlul commented

The next version of the extension will check for a ydkeQueryString flag and disable the shim DawnbrandBots/deck-transfer-for-master-duel@5343125. This will allow the deck builder to avoid redundancy if and when this is natively implemented :)

RillingDev commented

Suggestion: ydke=main!extra!side!name.

I am leaning towards keeping the name as a seperate query parameter, as it does not seem to be encoded in the YDKE URI by other tools, what are your thoughts on this?

kevinlul commented

You're free to include the name after the third !, it works out.

RillingDev commented

alright, so the current implementation is:
if the y query parameter is supplied, its content will be loaded as a deck.
the content is expected to be YDKE-data, followed by the deck name. the entire query parameter content should be URL encoded

kevinlul commented

Is this the idea? y=${encodeURIComponent("ydke://main!extra!side!name")}

RillingDev commented

Almost, its only the data portion of the YDKE, so y=${encodeURIComponent("main!extra!side!name")}

  • 👍1
kevinlul commented

FYI, the released version of the extension this week no longer uses the shim and uses the native feature described here. Firefox, Chrome, Edge, and Safari clients should be switching over. Opera has yet to publish the version, but Opera users may have installed the Chrome version.

  • ❤️1