Mobile App Plugin
Closed this issue · 3 comments
First of all this is amazing work!
However, I did clone your repo and noticed a lot of errors regarding the mobile app. Especially when saving settings or any function which takes multiple inputs. Currently, OSPi checks for input before trying to use them. In your revision, these checks are gone and the app breaks when trying to save options.
Also, I get the name difference however it will fail OSPi checks on the mobile app (looking specifically for OSPi). This will cause the app to behave incorrectly. Honestly, the mobile_app.py file sends the device name and so long that reads OSPi the rest of the app can still retain the name OSPy.
Would you mind looking into these? I think Dan would be happy to merge this especially with all conflicts resolved.
Thank you!
I will have a look at this issue next week. I'll need to have a look at how the app uses the server. As far as I know, the external interface shouldn't have changed.
The name will probably be changed back to OSPi once it is transferred back to Dan's repository.
Due to other business I didn't have time yet to look into this issue. Do you have any more details what the app uses and how my version responds differently? This would decrease the time I need to debug this issue and will probably get it fixed sooner.
Does the app only use the information/functionality provided by mobile_app.py or does it also use other interfaces to achieve its actions?
I will take a look at this. I discussed this with Dan and since we are merging with your branch I will spend some time/effort fixing what is needed to get my app working again. Minor things hopefully, thanks!