Icon more in style with gnome symbolic icons

Question

Icon more in style with gnome symbolic icons

corebots opened this issue a year ago · 5 comments

Hello and thank you for the extension! I've replaced your provided icons with two symbolic icons more in style with gnome symbolic icons. Would you be interested in a contribution? Of course, you might have reasons for using your icons and I respect that. But I thought I'd ask.... It's the one on the left in the screenshots. I'm also attachind them to this post in case you want them. Feel free to close otherwise.

Answer 1 · 2024-01-05T10:01:04.000Z

Hm! I like them! They are clearly more in style with the others, although I personally prefer the touch of color... but I understand this is clearly better from a graphical point of view.

But yes, I'll add them. Would you like to make a PR? Do you prefer I do the thing (will obviously attribute it correctly 😉)

(Can also add your icons and modify them with the red/green thing, and add an option defaulting to yours...)

Thnaks!

Answer 2 · 2024-01-05T10:09:29.000Z

BTW, probably my lack of knowledge --- opening the icons in Inkscape, they are basically invisible (they have no stroke paint defined). I suppose that is normal and made to avoid overriding the user's color scheme, but... ¿could you give a hint on how to edit/play with them? Or a link on how to draw icons for Gnome?

Answer 3 · 2024-01-05T19:23:52.000Z

Never mind, I did it ;-).

Answer 4 · 2024-01-05T19:30:26.000Z

@corebots , would you like to test it? Thanks!

Answer 5 · 2024-01-08T05:53:54.000Z

Hello! Sorry for the late response, I'm traveling Asia currently and not opening my laptop every day.

First of all thanks for accepting the icons :) I've updated your extension just now and it seems to work nicely!

Secondly, I have never contributed like this to an extension (or other project on github) so even if I'd to do it via a PR, I'll first need to find out how to do that (for possible future contributions, since now you've done all the work).

Then to your question about drawing the icons - what I do is to make a screenshot of an existing symbolic icon in the panel, then put it in Figma (or well Inkscape) make a frame of 16x16 px and draw the shapes with rounded corners so that it visually aligns with the screenshot I took as reference, leaving a gap of free space around them. In this case, I took a square of 12x12 px as a base + the stroke. Not really a proper guide I know, but it works :)