Supporting PHP 7

Question

Supporting PHP 7

WinterSilence opened this issue 3 years ago · 10 comments

Need copy common features to branch 4.x (PHP 7).

Reasons:

some new features in branch 5.x not related directly to PHP 8
PHP 8 using only in 6-10%

Answer 1 · 2022-01-20T12:57:59.000Z

You don't need to backport features; BR 5.1.x running in PHP 8 can analyse all older versions of PHP code, so it doesn't matter what version of PHP the codebase being analysed is, as long as the version of PHP running BR is PHP 8+

Answer 2 · 2022-01-20T13:03:33.000Z

@asgrim

PHP 8 using only in 6-10%

i.e. in 90-94% of cases can't use BetterReflection

Answer 3 · 2022-01-20T13:06:25.000Z

@asgrim

PHP 8 using only in 6-10%

i.e. in 90-94% of cases can't use BetterReflection

I repeat; the codebase being analysed, regardless of what PHP version the codebase needs, can still be analysed by BR if you run BR under PHP 8. I expect you don't even need to install PHP 8, you can probably just run it in a Docker container or something (not something we provide).

Answer 4 · 2022-01-20T13:09:54.000Z

@asgrim if server use PHP7 you can't install BetterReflection 5.x, but 4.x don't contain some common features added in 5.x

Answer 5 · 2022-01-20T13:12:48.000Z

@asgrim if server use PHP7 you can't use BetterReflection 5.x

BR is not designed to run in production, so it does not matter what version of PHP you run on your server/deployment environments. Specifically, on the front page of the README, it says:

Better Reflection is NOT suited to runtime usage, since performance is much worse than PHP built-in reflection.
If you do not want to do anything that native PHP reflection can't do, then just use native PHP reflection! The "Better"
in Better Reflection refers to feature, not speed!

Answer 6 · 2022-01-20T13:19:39.000Z

@asgrim "NOT suited to runtime usage" not same to "not designed to run in production"

Answer 7 · 2022-01-20T13:26:18.000Z

@asgrim for example, I'm using BR for generates sitemap by controller actions and autocomplete for template editor in back-end

Answer 8 · 2022-01-20T13:27:56.000Z

Closing: PHP 7 runtime aupport is NOT coming.

In fact, 8.0 support will be dropped when we decide to rely on 8.1 features.

Focus on upgrading your stack, please: you will have to do it anyway.

Alternatively, just run BetterReflection 4.x, which works fine on PHP 7.

Answer 9 · 2022-01-20T13:33:29.000Z

@Ocramius

some new features in branch 5.x not related directly to PHP 8

Answer 10 · 2022-01-20T13:39:57.000Z

@Ocramius

some new features in branch 5.x not related directly to PHP 8

Please stop quoting things you have already said, we already read the issue description.

I'm afraid new features are only available in the newer branches, and we do not plan to backport them.

If you must run PHP 7, then please use the 4.x series, which will continue to receive security fixes for now.

But again: I reiterate, you can run BR in PHP 8 to perform analysis on a PHP 7 codebase already. It's up to you how you want to make that happen.

If you would like consulting on how to actually do that for your situation, please contact me and I am happy to help you develop your solution, but that is paid support only.