RobSpectre/Trump-Filter

Google Analytics used

troskop opened this issue ยท 3 comments

Hi,
your App seems to use Google Analytics. [https://github.com/RobSpectre/Trump-Filter/blob/master/js/analytics.js]
According to EU-Law you are not allowed to use it unless you inform the user about this.
Even the description on the Chrome Webstore [https://chrome.google.com/webstore/detail/trump-filter/lhondapiaknegjpellpodegmeonigjic] has no annotation about this.

Moreover, you have to remove the IP of the user when using analytics.

ga('set', 'anonymizeIp', true);

Since this issue seems not to be resolved, i've reported it to the Google team.

Wow. It actually took longer to write that initial post than to do a pull request.

Given; you (personally) can't update the description of the extension in the Chrome Webstore, but still... A helpful nudge to get the change in motion is in the spirit of the open source community.

Pull request made, with a suggestion to update developer dashboard description for extension:
#11

This is not enough. This extension might leak sensitive information such as password reset links, auth tokens etc. It should not use google analytics or send any web traffic outside the user's browser.