RobTillaart/AD5245

Invalid isConnected function

timnicolas opened this issue · 3 comments

timnicolas commented

AD5245/AD5245.cpp

Line 29 in ce65605

if ((_address != 0x2C) || (_address != 0x2D)) return false;

This line will always return false.
May be you want to do

 if ((_address != 0x2C) && (_address != 0x2D)) return false;
RobTillaart commented

Thanks,
Will look into it later today..

RobTillaart commented

@tnicolas42
you're 100% right, I will create a PR (0.4.0) asap.
I might include some minor edits too.

If there are other things need to fix or you would like to have, do not hesitate to share,
Thanks for finding this bug.

RobTillaart commented

develop branch, PR created, build is running.