[Bug]: buff continue to stack
Closed this issue · 6 comments
Describe the bug you're experiencing
I upgraded my version from 1.20.1-v5.6.5 to 1.20.1-v5.7.3 and discovered this bug. I have not tested versions v5.7.0 to v5.7.2.
When a player swaps hands with an item (not an empty item) or runs, the buffs continue to stack, causing the magic shield, damage, resistance, etc., to reach very high values or their maximum limits.
Reproducability
Quickly switch the player’s hand item using the scroll wheel or hotkeys.
Mod up to date
- Before submitting this issue I updated to the newest version and reproduced it
Tested Without Custom Mine and Slash Datapacks
- In case I used Mine and Slash datapacks, I ran Mine and Slash in a new instance without custom datapacks and confirmed the bug still exists
Mine and Slash version
1.20.1-v5.7.3
Logs
https://gist.github.com/Oscar0159/303baf017cfba68773b3f128d3a31c77
Hm i can't reproduce this one right now, are you on the mine and slash discord?
yes
I'll drop a jar in #general , try if the bug still happens
Well found the reason, should be fixed next update ad31a61
The old system always produced new statcontexts on every gear calculation, so editing them was fine. New system caches them.. so editing is not good
Can you confirm the bug is fixed?
bug fixed