RoccoC/webpack-build-notifier

Property 'onClick' is missing

Closed this issue · 2 comments

muuvmuuv commented

Why do I need to handle onClick by myself? In the docs it says "by default" so I guess this should be optional:

Argument of type '{ title: string; }' is not assignable to parameter of type 'WebpackBuildNotifierConfig'.
  Property 'onClick' is missing in type '{ title: string; }' but required in type 'WebpackBuildNotifierConfig'.

see: index.d.ts#L96

RoccoC commented

You are right, onClick should be made optional.

RoccoC commented

Fixed in 0.1.32.

  • 🎉1