RockefellerArchiveCenter/dimes

Adding timestamp to DatePicker

Closed this issue · 4 comments

kcloud commented

We're wanting to add a timestamp to our DateTimePicker calendar, so archivists may schedule appointments. However, the current component (https://github.com/reecelucas/react-datepicker) does not include a timestamp. There seem to be many options. For a pull request and future enhancements, do you have a recommended integration?

helrond commented

I don't have a recommended library, but something that is important to us is ensuring we don't take a step backwards in terms of accessibility. With these kinds of elements keyboard navigation is important (and can be tricky!) so that would be my primary concern.

A couple of other questions:

  • Are we also going to need to look at what data is sent to Aeon? Do we need to add an additional field?
  • Is this intended to integrate/interact in some way with the appointment scheduling feature in Aeon? I don't know a lot about that, but had some conversations with Atlas that indicated that it might be hard to do that given the current Aeon integration pattern (POST requests with data).
kcloud commented

I concur with concerns for accessibility as well as future maintenance/dependency management.

  • I don't believe that Aeon supports time data within its date field. I think we'll need an additional field.
  • I do not expect to integrate with appointment scheduling in Aeon at this time. Our conversations with Atlas on the subject have been similar, and we have internal workarounds rather than using the API.
helrond commented

Thanks @kcloud - so we're going to need to make changes to Request Broker as well to support sending an additional field to Aeon. Off the top of my head I think that will likely need to happen here

ctgraham commented

@chryslovelace, I think I need you to participate in this repo before I can assign the issue to you.

We've used React Date Picker for our proposed implementation.

Some challenges we discussed: