Text strings are replacing UI elements
Closed this issue · 2 comments
HaSistrunk commented
Describe the bug
View Online and Download buttons are being replaced with text strings in the UI on the /object page in record details and on the /list page.
To reproduce
Steps to reproduce the behavior:
- Go to dimes.rockarch.org/objects/DQCoJGgCRXHnsPjKGiaCsZ
- See buttons in records details
- Add this item to your list
- Go to /list page
- See that "View Online" button is replaced with string of text
Error message or screenshots
Should be:
And on My List page:
Should be:
Additional context
This seems to be a bug related to the lingui translations, because those text strings are present in /src/locales/en/messages.js. However, I'm not seeing it in local development.
HaSistrunk commented
I'm also seeing this phenomenon in the footer:
helrond commented
Running yarn extract and yarn compile (which extracts and compiles messages using lingui) appears to have done the trick.
I think there are a couple of things we should do as a followup:
- Update the readme with a bit more information about when and how to extract and compile messages
- Consider rolling this into git pre-commit hooks and/or our CI pipeline in general