[BUG] Links to PRs, Merged PRs, and Issues detail no longer works
Sing-Li opened this issue · 1 comments
This is a major regression.
The links to PRs, Merged PRs, and Issues detail now REQUIRE the user to be logged onto Github to work.
This is unacceptable.
Any user, even those without Github account, should be able to view the details of these links. It will require some caching of the information.
One workable compromise might be to:
- detect if user is logged onto Github
- only display clickable link if logged on; otherwise display static count only
@Sing-Li I'll take this up.
Actually earlier the URL used for searching was https://github.com/pulls?q=is:pr+org:RocketChat+author:Darshilp326+is:open+created:%3E=2020-11-20 which required the user to logged in in order to work.
Changing it to https://github.com/search?q=type:pr+org:RocketChat+author:Darshilp326+is:open+created:%3E=2020-11-20 will work for all types of users.
Note I have changed the URL from pulls to search and query param from is:pr to type:pr
Screenshots(Incognito window):
