Dropdown to add-members is not closing when clicked somewhere on modal

Question

Dropdown to add-members is not closing when clicked somewhere on modal

umangutkarsh opened this issue 9 months ago · 5 comments

Description:

Dropdown to add-members is not closing when clicked somewhere on modal or when clicked to close the dropdown, it is only closed when clicked outside.

Steps to reproduce:

Start RocketChat server
Go on home-page
Click on Create Channel
Fill details and try to add members.
Now click somewhere on the modal or try to close the dropdown.

Expected behavior:

The dropdown should get closed when clicked on the modal somewhere or when clicked on the arrow-button to close it.

Actual behavior:

rc.webm

Server Setup Information:

Version of Rocket.Chat Server: v6.6.0-develop
Operating System: Windows 10 (running the server on gitpod)
NodeJS Version: v14.21.4
MongoDB Version: v6.0.3

Client Setup Information

Desktop App or Browser Version: Version 120.0.6099.199 (Official Build) (64-bit)
Operating System: Windows 10 (gitpod)

Answer 1 · 2024-01-08T12:24:32.000Z

Maintainers, should I start working on this one?

Answer 2 · 2024-01-08T16:38:35.000Z

No need to ask for permission to fix the issue, feel free to work on it!
Just check if someone it's already raised a PR for that (should be linked in this issue).
Best of luck 🚀 👏

Questions? Help needed? Feature Requests?

Join our Open Server in the #support channel and feel free to raise a question
Join our Community Forum and search/create a post there
Feature Request: Open an issue in Feature Request repository

Answer 3 · 2024-01-08T18:18:59.000Z

No need to ask for permission to fix the issue, feel free to work on it! Just check if someone it's already raised a PR for that (should be linked in this issue). Best of luck 🚀 👏

Questions? Help needed? Feature Requests?

Join our Open Server in the #support channel and feel free to raise a question

Join our Community Forum and search/create a post there

Feature Request: Open an issue in Feature Request repository

@hugocostadev . Thanks for this. Please assign this issue to me, I'm working on it.

Answer 4 · 2024-01-12T18:03:05.000Z

Hi @hugocostadev . I have created a PR for this issue. If the size-change of dropdown is an issue, then I'll make changes.
Please let me know.
Thanks

Answer 5 · 2024-01-12T18:31:37.000Z

@umangutkarsh, first of all, I appreciate your effort in submitting the PR, and I understand that this issue has been assigned to you. However, I'd like to bring up the point in a considerate manner that it appears the problem is rooted in the fuselage design system itself. I conducted a direct test by running the storybook, and it seems that addressing the issue solely within the app may not resolve the underlying problem.

@hugocostadev, I've also raised a corresponding issue in the fuselage repository and submitted a PR for it. I kindly request to do a verification, and please inform me if my assessment is accurate. You can find the links here: Issue - #1261, PR - #1262.